Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bool parameters in Entry/Exit to BlendTree optimization #982

Merged
merged 7 commits into from
Apr 4, 2024

Conversation

nekobako
Copy link
Contributor

@nekobako nekobako commented Apr 3, 2024

Fixes #981 です

@nekobako nekobako marked this pull request as ready for review April 3, 2024 11:16
@nekobako nekobako force-pushed the bool-entry-exit-to-blendtree branch from 3903ab0 to c5bf316 Compare April 3, 2024 16:49
Copy link
Owner

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます

Internal/AnimatorOptimizer/EntryExitToBlendTree.cs Outdated Show resolved Hide resolved
Internal/AnimatorOptimizer/EntryExitToBlendTree.cs Outdated Show resolved Hide resolved
@nekobako nekobako force-pushed the bool-entry-exit-to-blendtree branch from c5bf316 to b7f168a Compare April 4, 2024 12:42
@nekobako nekobako force-pushed the bool-entry-exit-to-blendtree branch from b7f168a to 3da301e Compare April 4, 2024 13:41
@nekobako
Copy link
Contributor Author

nekobako commented Apr 4, 2024

conventional commit と CHANGELOG のチェックに引っかかってしまったのですがどう対応すればよいでしょうか・・?

@anatawa12
Copy link
Owner

conventional commit と CHANGELOG のチェックに引っかかってしまったのですがどう対応すればよいでしょうか・・?

Actionsシステムのバグのようだったので再実行しました

Copy link
Owner

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コード自体は良さそうです

テストは未確認ですすみません

@nekobako
Copy link
Contributor Author

nekobako commented Apr 4, 2024

ありがとうございます。

Copy link
Owner

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

テストも良さそうですねありがとうございます

@anatawa12 anatawa12 merged commit d33d4a7 into anatawa12:master Apr 4, 2024
8 checks passed
@nekobako nekobako deleted the bool-entry-exit-to-blendtree branch April 4, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bool パラメータで動く Entry/Exit の BlendTree 化
2 participants