Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix skipped parameter values in Entry/Exit to BlendTree optimization #991

Merged
merged 4 commits into from
Apr 7, 2024
Merged

Fix skipped parameter values in Entry/Exit to BlendTree optimization #991

merged 4 commits into from
Apr 7, 2024

Conversation

nekobako
Copy link
Contributor

@nekobako nekobako commented Apr 7, 2024

Fixes #989

@nekobako nekobako marked this pull request as ready for review April 7, 2024 04:20
anatawa12
anatawa12 requested changes Apr 7, 2024
View reviewed changes
Copy link
Owner

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます

Internal/AnimatorOptimizer/EntryExitToBlendTree.cs Outdated Show resolved Hide resolved
@nekobako nekobako force-pushed the fix-skipped-parameter-values branch from 8eef84d to ef8eddf Compare April 7, 2024 08:57
anatawa12
anatawa12 approved these changes Apr 7, 2024
View reviewed changes
Copy link
Owner

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます

skipped valuesでその両側が同じアニメーションのパターンもテストを追加していただけるとありがたいです

@nekobako
Copy link
Contributor Author

nekobako commented Apr 7, 2024

テスト追加しました！

anatawa12
anatawa12 approved these changes Apr 7, 2024
View reviewed changes
Copy link
Owner

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます

@anatawa12 anatawa12 merged commit 1e911a1 into anatawa12:master Apr 7, 2024
8 checks passed
@nekobako nekobako deleted the fix-skipped-parameter-values branch April 7, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anatawa12 anatawa12 anatawa12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nekobako @anatawa12