-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More complete OpenAPI 3.1 support in zod-openapi
.
#173
Merged
Merged
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
43ff459
Remove `nullable`
A5rocks 33a01e8
exclusiveMinimum/exclusiveMaximum changes
A5rocks c1f26f1
examples changes
A5rocks f1e887a
Fixup zod-nestjs
A5rocks e360646
Some other last fixes I just realized
A5rocks 89578a7
Fix tests
A5rocks 68bbd74
Merge branch 'main' into openapi-3.1
A5rocks 2fc3f48
Try fixing up the tests after merge
A5rocks 58a40a5
Partially revert last PR regarding nullability
A5rocks 9fbe128
Actually riff off of that PR
A5rocks fd03bed
Fix test ordering
A5rocks ccc3490
Hopefully address PR review
A5rocks 51367ca
I forgot arrays were objects
A5rocks 0a4e99b
Merge branch 'main' into openapi-3.1
A5rocks 6fdba79
Fix test cases
A5rocks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove
'null'
from type array then. Besides, this doesn't work with string values (rather than arrays) which TypeScript allows here. See #182.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my changes make this work, but there's a case (or two) which I'm not sure about:
type: []
ortype: ["null"]
. What do you think should happen then?As of latest commit those should lead to
undefined
type which is... Idk, should this error instead?