Site names cannot contain '

[SpenserJ]

When you set the site name to something containing ' (single quote), it doesn't escape it and breaks the config file.

[ghost]

Is this in the installer?

[Makeshift]

Shouldn't matter, in theory. If a user follows the installer, then surely the installer can be coded to put in an escape? This only has an affect if the user edits settings manually and forgets to add an escape. Nonetheless, I'll give it a shot since you asked me to.

[ghost]

I guess we could use "double quotes".

[Makeshift]

Only way to do it that I can see is to use double quotes, unless it were coded to look for how it's written, and replace accordingly with a str_replace?
(Example:
if(stristr($sitename,'') === TRUE)
{
str_replace(', ', $sitename);
}
)

[ghost]

or str_replace(''', '’', $sitename);

It should be noted that I'm a type-nut.

[Makeshift]

Consider it noted. And my C+P failed hard, so it missed out part of the code.

[SpenserJ]

Oh my gosh. You guys kind of really suck at this :P VI did get the best solution though, as just replacing ' with ' would cause issues if I set my title to ' (you'd get '). Replacing ' with ’ will completely remove it, and use an HTML entity instead, which is safe.

As for where to implement this, you need it in both the installer, and when you save the settings. And when you load the settings, you have to make sure it renders properly as '

[ghost]

But there's no installer... Yet.

[ghost]

Did I fix this?

[SpenserJ]

Yes. You should have said Fix #5 in your commit message, as it would automatically close this issue.