fix: Update to support #101 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psududemike
force-pushed
the
add-support-for-whitelist-101
branch
from
20a4223 to
4bc80c1
Compare
Signed-off-by: Mike Frederick <mike.frederick@cesium.com>
psududemike
force-pushed
the
add-support-for-whitelist-101
branch
from
4bc80c1 to
574ed6a
Compare
spiffcs
approved these changes
Oct 3, 2024
|
@psududemike thanks so much for the PR here and adding the tests. I've updated it with main and will be getting this out ASAP |
spiffcs
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix that should allow more robust rules for grant. In specific this should support whitelisting and the coexistence of allow and deny rules in the policy. This partially fixes the issue raised in #101