Run checks on PRs from forks #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
alfredodeza
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we are triggering the static analysis and test workflow from push events, which forks for members of the repo, but not for PRs from a fork. This PR adds the
pull_requesttrigger to the static analysis and test workflow. Note: this will cause what appears to be duplicate checks for PRs originating from members of the repo, which happens on simultaneous push and PR events. This is somewhat undesirable behavior but the refs being checked are technically different --one running against the typical gitrefwhile the other is running againstrefs/pull/<prnum>/merge, as seen from theGITHUB_REF.