fix: higher default timeout for database download #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on region and network conditions, 120s was not enough time for many clients, leading to some complaints. Raise the default timeout to five minutes. Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
willmurphyscode
force-pushed
the
fix-higher-default-db-timeout
branch
from
76f8b01 to
dad653c
Compare
Given the above comment from discourseI think this is ok to merge now. I've approved this @willmurphyscode but left it to you to merge if you're looking to wait for any more data 👍 |
spiffcs
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on region and network conditions, 120s was not enough time for many clients, leading to some complaints. Raise the default timeout to five minutes.
There's an open question whether we should wait for more data from the latest attempt to resolve the CDN issues
Fixes #1885