Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor v5-specific code out of core packages #2299

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented Dec 4, 2024

This PR refactors some code to eliminate dependencies on v5 in core packages, including renaming grypeDB import aliases to v5 for increased clarity.

After this PR, the only references to v5 specific code, outside of the db/v5 packages are:

  • loading the vulnerability db (which is necessary in some way until switching to v6)
  • differ (which I believe is not going to be ported to v6 and should probably get moved under the db/v5 package)
  • tests mocking vulnerabilities using v5 data structures

This PR does not adjust any of the tests or the vulnerability.Provider/MetadataProvider interfaces

This is a prerequisite for #2132

Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow kzantow merged commit eee0fe5 into main Dec 4, 2024
10 checks passed
@kzantow kzantow deleted the chore/isolate-v5 branch December 4, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants