Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move docker login after keychain creation #261

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

wagoodman
Copy link
Contributor

Currently the release step logs into docker, however, this needs to occur after creating the keychain used for mac signing.

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Copy link
Member

@Btodhunter Btodhunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wagoodman wagoodman enabled auto-merge March 25, 2021 20:47
@wagoodman wagoodman merged commit 7ce9ef6 into main Mar 25, 2021
@wagoodman wagoodman deleted the move-docker-login-after-keychain-step branch March 25, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants