Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in syft v0.14.0 and further decouple presenters from Syft #263

Merged
merged 4 commits into from
Apr 1, 2021

Conversation

wagoodman
Copy link
Contributor

Pull in syft v0.14.0, mainly the changes from anchore/syft#339 . This requires a decoupling from the shared syft presenters for JSON and CycloneDX output formats. Additionally this PR removes the BD schema ref in the cycloneDX document output (which was only valid in 1.1 not 1.2) and bumps go version to 1.16.

@wagoodman wagoodman added the enhancement New feature or request label Mar 29, 2021
@wagoodman wagoodman requested a review from a team March 29, 2021 14:47
@wagoodman wagoodman self-assigned this Mar 29, 2021
@wagoodman wagoodman force-pushed the pull-syft-cataloger-refactor branch from 98f59a8 to 7fdf7f2 Compare March 29, 2021 14:48
cmd/root.go Outdated Show resolved Hide resolved
@wagoodman wagoodman force-pushed the pull-syft-cataloger-refactor branch from 438c2fb to d11185c Compare April 1, 2021 13:58
wagoodman and others added 4 commits April 1, 2021 10:01
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Co-authored-by: Alfredo Deza <adeza@anchore.com>

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@wagoodman wagoodman force-pushed the pull-syft-cataloger-refactor branch from d11185c to 246e47b Compare April 1, 2021 14:01
@wagoodman wagoodman enabled auto-merge April 1, 2021 14:01
Copy link
Contributor

@luhring luhring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Adding a note from our discussion yesterday: going forward, we'll try to minimize changes based solely on "consistency" with Syft while the two tools are undergoing some flux for the time being

@wagoodman wagoodman disabled auto-merge April 1, 2021 16:13
@wagoodman wagoodman merged commit 24fa1f2 into main Apr 1, 2021
@wagoodman wagoodman deleted the pull-syft-cataloger-refactor branch April 1, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants