Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add repo digests onto image metadata #274

Merged
merged 2 commits into from
Apr 1, 2021
Merged

Add repo digests onto image metadata #274

merged 2 commits into from
Apr 1, 2021

Conversation

wagoodman
Copy link
Contributor

Bumps the version of syft to pull in repoDigsets on the source.ImageMetadata struct.

Closes #269

@wagoodman wagoodman requested a review from a team April 1, 2021 21:02
@wagoodman wagoodman self-assigned this Apr 1, 2021
@wagoodman
bump syft to pull in repoDigests onto image metadata
b308c4a 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman force-pushed the pull-in-repo-digests branch from db528d0 to b308c4a Compare April 1, 2021 21:03
@wagoodman wagoodman enabled auto-merge April 1, 2021 21:04
luhring
luhring approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@luhring luhring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't see repo digests in the updated test output (just the new empty array), but I'm assuming we test for repo digests in the output tests for Syft...

@wagoodman wagoodman disabled auto-merge April 1, 2021 21:24
@wagoodman wagoodman enabled auto-merge (squash) April 1, 2021 21:25
@wagoodman wagoodman merged commit ebe1371 into main Apr 1, 2021
@wagoodman wagoodman deleted the pull-in-repo-digests branch April 1, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhring luhring luhring approved these changes

Assignees

@wagoodman wagoodman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report the repo digests in the JSON output source section
2 participants
@wagoodman @luhring