Update output-format and acs-report-enable disconnect #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiffcs
approved these changes
Sep 14, 2022
| } else { | ||
| cmdArgs.push("-o", outputFormat); | ||
| } | ||
| cmdArgs.push("-o", outputFormat); |
There was a problem hiding this comment.
Nice, this makes it much easier to read and simplifies everything.
Signed-off-by: Keith Zantow <kzantow@gmail.com>
kzantow
force-pushed
the
update-output-format-acs
branch
from
814bdb5
to
99214db
Compare
|
Restored the CHANGELOG 👍 |
|
@maartenh NOTE: I've updated the output variable name to |
|
@kzantow That seems like a good idea with the current 2 format options. |
dirkmueller
added a commit
to dirkmueller/BCI-tests
that referenced
this pull request
Nov 23, 2022
This parameter is no longer supported in @V3, and replaced by output-format: sarif, which is however the default see anchore/scan-action#192 for context
dirkmueller
added a commit
to dirkmueller/BCI-tests
that referenced
this pull request
Nov 23, 2022
This parameter is no longer supported in @V3, and replaced by output-format: sarif, which is however the default see anchore/scan-action#192 for context
jayaddison
added a commit
to grocy/grocy-docker
that referenced
this pull request
Mar 31, 2023
…n-action configuration in container publish workflow This is (and was) the default for the action; ref: anchore/scan-action#192
rcmadhankumar
pushed a commit
to SUSE/BCI-tests
that referenced
this pull request
Aug 30, 2024
This parameter is no longer supported in @V3, and replaced by output-format: sarif, which is however the default see anchore/scan-action#192 for context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #187 which renames the json output file to more closely align to the
output-formatoption ofjsonorsarif, as well as removing theacs-report-enableflag, which is no longer necessary.NOTE: this is not really a breaking change, as the defaults of
output-format=sarifandacs-report-enable=truewill result in the same behavior.