Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add format make target #170

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Add format make target #170

merged 3 commits into from
Apr 12, 2023

Conversation

wagoodman
Copy link
Contributor

Splits the format-related tasks in the lint-fix target into a new format target (which lint-fix depends on).

Additionally updates the linter, lint targets, and thus there are code changes due to new linting behaviors. (The Makefile is the main file for review)

@wagoodman
fix linting
f195073 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman
add format make target
8dd9686 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman
add developing reference to format target
d9cc960 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@github-actions
Copy link

github-actions bot commented Apr 12, 2023 •
edited
Loading

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
latest: Pulling from library/ubuntu
tar: Option --mtime: Treating date 'UTC 2019-09-16' as 2019-09-16 00:00:00
goos: linux
goarch: amd64
pkg: github.com/anchore/stereoscope/pkg/file
cpu: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
docker: 
           │ ./.tmp/benchmark-6fc3a47.txt │
           │            sec/op            │
TarIndex-2                   42.42µ ± ∞ ¹
¹ need >= 6 samples for confidence interval at level 0.95

           │ ./.tmp/benchmark-6fc3a47.txt │
           │             B/op             │
TarIndex-2                  5.560Ki ± ∞ ¹
¹ need >= 6 samples for confidence interval at level 0.95

           │ ./.tmp/benchmark-6fc3a47.txt │
           │          allocs/op           │
TarIndex-2                    93.00 ± ∞ ¹
¹ need >= 6 samples for confidence interval at level 0.95

pkg: github.com/anchore/stereoscope/test/integration
                                      │ ./.tmp/benchmark-6fc3a47.txt │
                                      │            sec/op            │
SimpleImage_GetImage/docker-archive-2                   1.523m ± ∞ ¹
SimpleImage_GetImage/oci-archive-2                      1.233m ± ∞ ¹
SimpleImage_GetImage/oci-dir-2                          814.9µ ± ∞ ¹
geomean                                                 1.152m
¹ need >= 6 samples for confidence interval at level 0.95

                                      │ ./.tmp/benchmark-6fc3a47.txt │
                                      │             B/op             │
SimpleImage_GetImage/docker-archive-2                  360.5Ki ± ∞ ¹
SimpleImage_GetImage/oci-archive-2                     645.2Ki ± ∞ ¹
SimpleImage_GetImage/oci-dir-2                         412.4Ki ± ∞ ¹
geomean                                                457.8Ki
¹ need >= 6 samples for confidence interval at level 0.95

                                      │ ./.tmp/benchmark-6fc3a47.txt │
                                      │          allocs/op           │
SimpleImage_GetImage/docker-archive-2                   2.789k ± ∞ ¹
SimpleImage_GetImage/oci-archive-2                      1.566k ± ∞ ¹
SimpleImage_GetImage/oci-dir-2                          1.350k ± ∞ ¹
geomean                                                 1.807k
¹ need >= 6 samples for confidence interval at level 0.95

docker: Error response from daemon: Get "http://localhost/v2/": dial tcp [::1]:80: connect: connection refused.
                                                   │ ./.tmp/benchmark-6fc3a47.txt │
                                                   │            sec/op            │
SimpleImage_FetchSquashedContents/docker-archive-2                   17.50µ ± ∞ ¹
¹ need >= 6 samples for confidence interval at level 0.95

                                                   │ ./.tmp/benchmark-6fc3a47.txt │
                                                   │             B/op             │
SimpleImage_FetchSquashedContents/docker-archive-2                  2.648Ki ± ∞ ¹
¹ need >= 6 samples for confidence interval at level 0.95

                                                   │ ./.tmp/benchmark-6fc3a47.txt │
                                                   │          allocs/op           │
SimpleImage_FetchSquashedContents/docker-archive-2                    21.00 ± ∞ ¹
¹ need >= 6 samples for confidence interval at level 0.95

@wagoodman wagoodman requested a review from a team April 12, 2023 18:06
@wagoodman wagoodman enabled auto-merge (squash) April 12, 2023 18:22
kzantow
kzantow approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gosimports-ed, nice!

@wagoodman wagoodman merged commit 8602f1a into main Apr 12, 2023
@wagoodman wagoodman deleted the make-format branch April 12, 2023 18:37
gnmahanth pushed a commit to deepfence/stereoscope that referenced this pull request Jun 15, 2023
@wagoodman @gnmahanth
Add format make target (anchore#170)
abe6881 
* fix linting

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

* add format make target

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

* add developing reference to format target

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

---------

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzantow kzantow kzantow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagoodman @kzantow