-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add use-all-catalogers flag #1050
Conversation
7e1855c
to
6d10830
Compare
While #1038 allows us to use the config to turn on certain catalogers, I think it would be easier for my use case, using all of them, to have a general switch to turn them all on. If there is an in between you all like, happy to adjust accordingly and contribute it. |
Thanks for the PR here @cpendery! Rather than make a new flag here I think we'd like to extend on the work done in #1038. Notice how the config can now take a []string as syft/internal/config/application.go Line 50 in 546eaec
Test showing the catalogers option syft/test/cli/packages_cmd_test.go Lines 230 to 237 in 546eaec
If we use the flag Let me know what you think of this direction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added small comment about use of new flag vs extending a newly merged flag
I think extending the existing flag makes a lot of sense. I'll switch over to using that flag and part of the config 👍 |
Signed-off-by: cpendery <cpendery@vt.edu>
* main: (70 commits) fix: add php catalogers to all catalogers (anchore#1065) feat: add use-all-catalogers flag (anchore#1050) Updates parsing of `yarn.lock` to use `resolved` URLs that are pulled from yarn and npm registries (anchore#926) remove OSS Meetup message (anchore#1057) add pom.xml cataloger (anchore#1055) Add support for CBL-Mariner distroless images (anchore#1045) Add catalogers configuration (anchore#1038) add template output (anchore#1051) update stereoscope to latest version (anchore#1052) update zip_read_closer to incorporate zip64 support (anchore#1041) Add pacman (alpm) parser support (anchore#943) Update of README.md (anchore#1027) bump cosign to v1.9.0 to resolve reporting of GHSA-66x3-6cw3-v5gj (anchore#1025) add workflows to test new project automation (anchore#1023) improve LanguageByName and add unit tests (anchore#1034) Read Description from dpkg status files (anchore#996) Add announcement for Anchore OSS Virtual Meetup (anchore#1033) add main module field to go bin metadata (anchore#1026) Add filters to package cataloger (anchore#1021) change draft to false for release process (anchore#1016) ... Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Description
Add a new switch
--use-all-catalogers
that allows for the use of both image and file catalogers to run on the subject. This is useful when scanning an image built to use as a build environment, where artifacts may be installed using the files present soon.Closes #1049