Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check pom properties for version (#1251) #1278

Merged
merged 4 commits into from
Oct 27, 2022
Merged

Conversation

chtompki
Copy link
Contributor

I think this closes #1251. I'm not sure but there may be an analogous issue with gradle. I'll see if I can find and example and submit a similar fix.

@kzantow kzantow self-assigned this Oct 21, 2022
@kzantow kzantow changed the title fix check pom properties for version (#1251) fix: check pom properties for version (#1251) Oct 21, 2022
@chtompki
Copy link
Contributor Author

@kzantow - I think that last commit accomplishes what you're looking for. Let me know

Signed-off-by: Rob Tompkins <chtompki@apache.org>
Signed-off-by: Rob Tompkins <chtompki@apache.org>
@kzantow
Copy link
Contributor

kzantow commented Oct 24, 2022

@chtompki -- if you'd like, I can make a couple small updates to this that I think will get it to the finish line

@chtompki
Copy link
Contributor Author

Go for it. I'm curious to see what you do. I'll learn from that and try to use that style for any future PRs I submit

@kzantow
Copy link
Contributor

kzantow commented Oct 25, 2022

@chtompki thanks -- I went down a little bit of a rabbit hole that I wouldn't expect most people to do in order to support project properties like ${project.parent.groupId}, which I've seen used enough to justify adding support for this while we're touching the property resolution. I've used some reflection for this because the gopom library has appropriate xml tags to make this fairly generic processing. We still need a solution for resolving parent and dependency poms, as well as dealing with dependencyManagement, but those aspects are both outside the scope of this change, I think.

@chtompki
Copy link
Contributor Author

Cool...I see what you've done here, and that helps me think about the way I might make an analogous change for gradle. I don't have a good example for gradle yet, and I've only seen it once. But, I'm thinking about trying to make that my next contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versions not printed out properly from maven pom.xml
3 participants