Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove bumping cosign in go.mod when updating bootstrap tools #1452

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

westonsteimel
Copy link
Contributor

Since cosign is no longer a direct dependency of syft, no need to bump it in the go.mod file as part of the bootstrap tools auto-update workflow

Signed-off-by: Weston Steimel <weston.steimel@anchore.com>
@westonsteimel westonsteimel requested a review from a team January 12, 2023 21:07
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    13.4ms ± 7%    15.9ms ± 3%  +18.29%  (p=0.008 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.41ms ± 1%    1.86ms ±13%  +32.08%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            3.64ms ± 1%    4.51ms ± 2%  +23.67%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.17ms ± 0%    1.46ms ± 1%  +24.52%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         857µs ± 1%    1054µs ± 5%  +23.01%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     974µs ± 0%    1194µs ± 2%  +22.57%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                    1.43ms ± 1%    1.71ms ± 2%  +19.76%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      16.0ms ± 1%    18.5ms ± 1%  +15.57%  (p=0.008 n=5+5)
ImagePackageCatalogers/graalvm-native-image-cataloger-2      7.76µs ± 3%    9.83µs ± 3%  +26.78%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      963µs ± 0%    1194µs ± 2%  +24.07%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          15.8µs ± 1%    19.4µs ± 1%  +23.14%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.53ms ± 2%    1.82ms ± 1%  +18.84%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    808µs ± 0%    1017µs ± 2%  +25.80%  (p=0.008 n=5+5)
ImagePackageCatalogers/sbom-cataloger-2                      4.80ms ± 1%    5.88ms ± 3%  +22.34%  (p=0.008 n=5+5)
ImagePackageCatalogers/binary-cataloger-2                    6.31ms ± 0%    7.64ms ± 3%  +20.98%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.29MB ± 0%    5.29MB ± 0%   +0.01%  (p=0.032 n=5+4)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               209kB ± 0%     209kB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             975kB ± 0%     976kB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     222kB ± 0%     222kB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         161kB ± 0%     161kB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     205kB ± 0%     204kB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/rpm-db-cataloger-2                     306kB ± 0%     306kB ± 0%     ~     (p=0.548 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.53MB ± 0%    3.53MB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/graalvm-native-image-cataloger-2      1.41kB ± 0%    1.41kB ± 0%     ~     (all equal)
ImagePackageCatalogers/apkdb-cataloger-2                      186kB ± 0%     186kB ± 0%   -0.06%  (p=0.032 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          1.85kB ± 0%    1.85kB ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                384kB ± 0%     385kB ± 0%   +0.18%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    141kB ± 0%     141kB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/sbom-cataloger-2                       742kB ± 0%     742kB ± 0%   +0.02%  (p=0.008 n=5+5)
ImagePackageCatalogers/binary-cataloger-2                    1.01MB ± 0%    1.01MB ± 0%   -0.02%  (p=0.008 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.8k ± 0%     85.8k ± 0%     ~     (p=0.095 n=4+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               4.35k ± 0%     4.35k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             16.8k ± 0%     16.8k ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.61k ± 0%     5.61k ± 0%     ~     (p=0.095 n=5+4)
ImagePackageCatalogers/javascript-package-cataloger-2         3.43k ± 0%     3.43k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.57k ± 0%     4.57k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpm-db-cataloger-2                     8.30k ± 0%     8.30k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       58.3k ± 0%     58.3k ± 0%     ~     (p=0.595 n=5+5)
ImagePackageCatalogers/graalvm-native-image-cataloger-2        32.0 ± 0%      32.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/apkdb-cataloger-2                      5.33k ± 0%     5.33k ± 0%     ~     (p=0.571 n=4+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            55.0 ± 0%      55.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                7.23k ± 0%     7.23k ± 0%     ~     (all equal)
ImagePackageCatalogers/portage-cataloger-2                    3.68k ± 0%     3.68k ± 0%     ~     (all equal)
ImagePackageCatalogers/sbom-cataloger-2                       25.3k ± 0%     25.3k ± 0%     ~     (all equal)
ImagePackageCatalogers/binary-cataloger-2                     34.5k ± 0%     34.5k ± 0%     ~     (all equal)

@spiffcs spiffcs merged commit e87cfe7 into main Jan 12, 2023
@spiffcs spiffcs deleted the remove-cosign-go-mod-update branch January 12, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants