Fix cataloger selection to be more specific #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
spiffcs
approved these changes
Feb 17, 2023
|
@wagoodman code looks good - there is a weird error in CI whee the the AT won't pass |
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
wagoodman
force-pushed
the
workaround-cataloger-selection
branch
from
4047734
to
93eee4d
Compare
|
CI issue workaround applied, see #1584 |
This was referenced Feb 22, 2023
Closed
This was referenced Mar 2, 2023
Closed
This was referenced Mar 6, 2023
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the cataloger selection allows for partial name matches, so input such as
gowill select all go catalogers:Unfortunately the current implementation takes a simplistic approach (a simple substring check) which causes additional false selections across ecosystems, which would most likely be unintentional. For instance, the same
gosearch would additionally select:This PR applies a workaround to make this behavior a little better before #1383 lands in a release (which fixes this behavior entirely).
The new behavior restricts the substring check to only allow for full words, separated by
-. This still allows for the current selection behavior today but fixes all of the (incorrect) cross selections I could find.Closes #1573