Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haproxy binary matcher #1591

Merged
merged 5 commits into from
Feb 23, 2023
Merged

haproxy binary matcher #1591

merged 5 commits into from
Feb 23, 2023

Conversation

noqcks
Copy link
Contributor

@noqcks noqcks commented Feb 18, 2023

Matching here was a little more difficult as some versions of HAProxy have semvers after text like this HA-Proxy version 1.5.14 while some have it before like this 2.7.3-1065b10HAProxy version

I couldn't find a way match HAProxy either before OR after the version match group in one regex, so I split into two.

Images used in test-fixtures

haproxy:1.8.22-alpine
haproxy:1.5.14
haproxy:2.7.3

Closes #1512

@noqcks
haproxy binary matcher
2fa8442 
Signed-off-by: Benji Visser <benji@093b.org>
@noqcks
Copy link
Contributor Author

noqcks commented Feb 18, 2023

Not sure why these tests are failing, my branch is up to date w/ main

@noqcks
adding evidenceMatchers function
2ccdf97 
Signed-off-by: Benji Visser <benji@093b.org>
@noqcks noqcks requested a review from kzantow February 23, 2023 19:31
kzantow
kzantow approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@kzantow kzantow merged commit abfec62 into anchore:main Feb 23, 2023
@noqcks noqcks deleted the benji/haproxy-binary-classifier branch February 23, 2023 20:11
This was referenced Mar 2, 2023
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Open
Open
Open
Open
Open
This was referenced Mar 10, 2023
Open
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Mar 20, 2023
Closed
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@noqcks
feat: haproxy binary matcher (anchore#1591)
6945b6e 
Signed-off-by: Benji Visser <benji@093b.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzantow kzantow kzantow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Catalog haproxy binary
2 participants
@noqcks @kzantow