Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rebar lock file decoding panic #1628

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented Feb 27, 2023

rebar.lock files with git entries caused a panic when parsing. This PR corrects the issue and makes the parser more robust without relying on regexes.

Fixes #1621

Signed-off-by: Keith Zantow <kzantow@gmail.com>
Copy link
Contributor

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice refactor 😎

@kzantow kzantow merged commit 2e6e3b0 into anchore:main Mar 1, 2023
@kzantow kzantow deleted the fix/rebar-lock-panic branch March 1, 2023 15:08
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syft erlang cataloger can segfault when analyzing an erlang project containing rebar.lock with nested deps
2 participants