Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix acceptance tests & add notification upon failures #204

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

wagoodman
Copy link
Contributor

Acceptance tests do not occur within the PR checks, which means it is possible for a passing PR to fail after being merged to main (when acceptance tests run). This PR fixes the existing failures and adds notifications to the toolbox channel when a failure is seen.

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman added bug Something isn't working enhancement New feature or request labels Oct 7, 2020
@wagoodman wagoodman self-assigned this Oct 7, 2020
@wagoodman wagoodman requested a review from Toure October 8, 2020 15:05
Copy link
Contributor

@luhring luhring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@wagoodman wagoodman merged commit da0eb6f into main Oct 8, 2020
@wagoodman wagoodman deleted the fix-acceptance branch October 8, 2020 15:07
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants