Added a cataloger for PHP PECL Packages #2604
Merged
+2,637
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentGoderre
force-pushed
the
php-pecl
branch
2 times, most recently
from
dffa0db to
a32740a
Compare
This comment has been minimized.
This comment has been minimized.
LaurentGoderre
force-pushed
the
php-pecl
branch
from
a32740a to
10b6ad0
Compare
LaurentGoderre
force-pushed
the
php-pecl
branch
from
10b6ad0 to
863a9d0
Compare
LaurentGoderre
force-pushed
the
php-pecl
branch
from
863a9d0 to
b79cb8e
Compare
LaurentGoderre
force-pushed
the
php-pecl
branch
from
b79cb8e to
c9c007e
Compare
LaurentGoderre
force-pushed
the
php-pecl
branch
2 times, most recently
from
55d35a0 to
c459aef
Compare
|
@pombredanne fyi |
LaurentGoderre
force-pushed
the
php-pecl
branch
2 times, most recently
from
eb48968 to
c2e1d96
Compare
kzantow
reviewed
Mar 28, 2024
There was a problem hiding this comment.
Thanks @LaurentGoderre! I noted a couple of small things to update and the rest looks good; shout if you need help with any of it
|
@kzantow Updated |
kzantow
reviewed
Apr 2, 2024
There was a problem hiding this comment.
Thanks @LaurentGoderre! The schema looks good now. I left a few more comments about the type assertions -- these will need to get updated. Consider the other comments non-blocking
Signed-off-by: Laurent Goderre <laurent.goderre@docker.com>
|
@kzantow updated |
kzantow
approved these changes
Apr 2, 2024
brian-ebarb
pushed a commit
to brian-ebarb/syft
that referenced
this pull request
Apr 17, 2024
Signed-off-by: Laurent Goderre <laurent.goderre@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for PHP PECL and PEAR extensions: https://pecl.php.net/