python requirements.txt cataloger: allow dots in python package names #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mikcl <mikesmikes400@gmail.com>
Mikcl
changed the title
spiffcs
approved these changes
Jul 25, 2024
|
@Mikcl thank you so much for the two PR regarding the python cataloger These will help a lot going into next release and we really appreciate the time and good PR description/submissions. |
|
Thanks for the quick review turn around @spiffcs note the test case in this pr should now be updated since the name and purl are normalised, from the other pr made. Thanks again |
|
put up a pr to fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its perfectly valid for python packages to have dots in their name
https://packaging.python.org/en/latest/specifications/name-normalization/
It seems like #1966 introduced a regex match which did not include the dot. This results in silently skipping packages with dots in their requirements.txt.
This PR accepts the dot and adds a test.
Noticed this whilst doing #3069 (which does the normalization of the name)
(its possible that this bug may exist in the other parsers but did not investigate that)