Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: --enrich flag for data enrichment feature enablement #3182

Merged
merged 18 commits into from
Sep 12, 2024

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented Sep 1, 2024

This PR introduces an --enrich flag, to allow Syft to enable data enrichment operations for all catalogers with a single flag. These operations often involve network requests to services like Maven Central, NPM, or GitHub. In the future there are likely to be an increasing number of remote network services that Syft is able to utilize, and this would be the first step to enabling that easily and automatically opting-in to future enrichment operations for all users who want the best quality SBOM they can get.

The easiest way to enable everything, is to use --enrich all, and Syft will enable all enrichment operations, which currently include Golang local and remote searches, Maven local and remote searches, and NPM lookups. This PR also supports enabling and disabling individual cataloger data data enhancement if there are any reasons to do so.

…logers

Signed-off-by: Keith Zantow <kzantow@gmail.com>
wagoodman
wagoodman previously approved these changes Sep 3, 2024
Copy link
Contributor

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(pending the fangs update)

Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow
Copy link
Contributor Author

kzantow commented Sep 4, 2024

A few questions came up during discussions, so I'm not going to merge this as-is; will get some feedback first

@kzantow kzantow dismissed wagoodman’s stale review September 4, 2024 18:33

There are probably going to be changes after discussion

Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow kzantow changed the title feat: --use-network flag for top-level network enablement feat: --enrich flag for data enrichment feature enablement Sep 5, 2024
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow kzantow merged commit 1b86326 into anchore:main Sep 12, 2024
12 checks passed
@kzantow kzantow deleted the feat/use-network-flag branch September 12, 2024 14:45
@kzantow kzantow added the enhancement New feature or request label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants