Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespace value for OpenSUSE distros #3615

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

mprpic
Copy link
Contributor

@mprpic mprpic commented Jan 23, 2025

Description

Instead of namespacing them to the specific distro version, such as Leap or Tumbleweed, the namespace value is set to the vendor itself: "opensuse".

This change is similar to that made in #2914.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added unit tests that cover changed behavior
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections

Instead of namespacing them to the specific distro version, such as
Leap or Tumbleweed, the namespace value is set to the vendor itself:
"opensuse".

Resolves anchore#3534

Signed-off-by: Martin Prpič <mprpic@redhat.com>
@spiffcs spiffcs merged commit 58dc43d into anchore:main Jan 28, 2025
12 checks passed
@spiffcs
Copy link
Contributor

spiffcs commented Jan 28, 2025

Thanks @mprpic - change LGTM. I'll follow up with #3534 to double check this behavior and see if there are any other edge cases we might want to cover in a follow up PR

@spiffcs spiffcs self-assigned this Jan 28, 2025
spiffcs added a commit that referenced this pull request Jan 30, 2025
* main: (67 commits)
  chore(deps): bump github/codeql-action from 3.28.7 to 3.28.8 (#3634)
  docs: update descriptions with correct options (#3630)
  chore(deps): bump github.com/gkampitakis/go-snaps from 0.5.8 to 0.5.9 (#3627)
  chore(deps): bump github/codeql-action from 3.28.6 to 3.28.7 (#3628)
  feat: update licenses to including license content when SPDX expressions are unable to be determined (#3366)
  fix: update namespace value for OpenSUSE distros (#3615)
  chore(deps): bump github/codeql-action from 3.28.5 to 3.28.6 (#3625)
  chore(deps): update CPE dictionary index (#3620)
  chore(deps): bump github.com/bmatcuk/doublestar/v4 from 4.8.0 to 4.8.1 (#3621)
  chore(deps): bump github/codeql-action from 3.28.4 to 3.28.5 (#3622)
  chore(deps): bump github/codeql-action from 3.28.3 to 3.28.4 (#3618)
  chore(deps): bump anchore/sbom-action from 0.17.9 to 0.18.0 (#3619)
  chore(deps): update tools to latest versions (#3607)
  chore(deps): bump github/codeql-action from 3.28.2 to 3.28.3 (#3608)
  chore(deps): bump github.com/go-git/go-git/v5 from 5.13.1 to 5.13.2 (#3609)
  chore(deps): bump github.com/docker/docker (#3610)
  chore(deps): bump actions/setup-go in /.github/actions/bootstrap (#3612)
  chore(deps): bump actions/cache in /.github/actions/bootstrap (#3613)
  chore(ci): fix composite GitHub action path in dependabot config (#3611)
  chore(deps): update tools to latest versions (#3602)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

RPM-based PURLs sometimes have incorrect namespace (specifically OpenSUSE)
2 participants