Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure credentials are not HTML encoded #368

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

wagoodman
Copy link
Contributor

Pulls in fix from anchore/stereoscope#63

…oded

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman added the bug Something isn't working label Apr 5, 2021
@wagoodman wagoodman requested a review from a team April 5, 2021 18:21
@wagoodman wagoodman self-assigned this Apr 5, 2021
@wagoodman wagoodman enabled auto-merge April 5, 2021 18:23
@github-actions
Copy link

github-actions bot commented Apr 5, 2021

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                   old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           815µs ± 4%     956µs ± 4%  +17.28%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2         969µs ± 2%    1128µs ± 3%  +16.35%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     414µs ± 3%     472µs ± 2%  +13.86%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 371µs ± 2%     414µs ± 2%  +11.55%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  432µs ± 3%     468µs ± 3%   +8.24%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  5.43ms ± 4%    6.38ms ± 2%  +17.34%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  563µs ± 4%     619µs ± 2%  +10.01%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-cataloger-2                     207µs ± 3%     236µs ± 1%  +13.93%  (p=0.008 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                   328µs ± 1%     377µs ± 3%  +15.07%  (p=0.008 n=5+5)

name                                                   old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           100kB ± 0%     100kB ± 0%     ~     (p=0.310 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2         481kB ± 0%     481kB ± 0%     ~     (p=0.452 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     109kB ± 0%     109kB ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 104kB ± 0%     104kB ± 0%   -0.10%  (p=0.016 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  134kB ± 0%     134kB ± 0%     ~     (p=0.905 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  1.69MB ± 0%    1.69MB ± 0%     ~     (p=0.095 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                 1.13MB ± 0%    1.13MB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/go-cataloger-2                    47.9kB ± 0%    47.8kB ± 0%   -0.10%  (p=0.040 n=5+5)
ImagePackageCatalogers/rust-cataloger-2                  87.3kB ± 0%    87.3kB ± 0%   -0.01%  (p=0.029 n=4+4)

name                                                   old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           2.16k ± 0%     2.16k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2         5.47k ± 0%     5.47k ± 0%     ~     (all equal)
ImagePackageCatalogers/javascript-package-cataloger-2     1.92k ± 0%     1.92k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                 2.20k ± 0%     2.20k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                  3.18k ± 0%     3.18k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                   22.0k ± 0%     22.0k ± 0%     ~     (p=0.167 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  1.79k ± 0%     1.79k ± 0%     ~     (p=0.167 n=5+5)
ImagePackageCatalogers/go-cataloger-2                     1.39k ± 0%     1.39k ± 0%     ~     (all equal)
ImagePackageCatalogers/rust-cataloger-2                   2.74k ± 0%     2.74k ± 0%     ~     (all equal)

@wagoodman wagoodman merged commit 7a10cba into main Apr 5, 2021
@wagoodman wagoodman deleted the fix-registry-auth-encode-issue branch April 5, 2021 18:25
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
…issue

Ensure credentials are not HTML encoded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants