-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nix install details #800
Conversation
Thanks for the PR @06kellyjac! Please make sure the commits are signed and verified. See this documentation for more details docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you also be able to include a screenshot showing this running on nix-os? I don't have a platform to verify this on at the moment.
Ahh, I thought it was just DCO |
I'll push a commit this morning that fixes the integration tests here. Looks like SPDX updated their license list over the weekend as well. |
nix can be used on linux distros other than NixOS and can be used on darwin We build syft (and other golang tools) for these targets:
My macOS vm: My NixOS machine:
|
4e146bf
to
2898ba6
Compare
Should I add a note about syft being in the unstable channel currently awaiting the 22.05 release? (in march) |
I think that's a good idea 👍 |
2898ba6
to
7721986
Compare
7721986
to
1b8d4dc
Compare
(rebased to pull in a fix for failing integration tests) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I combined the two phrases into one, other than that just awaiting passing CI. Thanks for providing the Nix packaging for Syft!! 🚀
@06kellyjac looks like there is a small problem with the DCO signoff:
I didn't see the problem at first until @luhring pointed it out:
Can you adjust the signoff to match the committer details? |
I updated the dco to |
Signed-off-by: 06kellyjac <jack@control-plane.io>
eab98ff
to
cd299a0
Compare
Signed-off-by: 06kellyjac <jack@control-plane.io>
Added install details for nix
I'd also like to say I'm also happy to help out with the nix cataloger (#462) if you push it to a draft PR