Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce PR check failures #858

Merged
merged 4 commits into from
Mar 2, 2022
Merged

Reduce PR check failures #858

merged 4 commits into from
Mar 2, 2022

Conversation

wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Mar 2, 2022

  • Adds polling check for install tests to ensure the snapshot server is up
  • Elevates CodeQL to only run on main (not on PRs)
  • De-duplicates checks as best as possible; CI checks only run on PRs and pushes to main. Pushes to feature branches will no longer trigger CI.

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman added the WIP work in progress / do not merge label Mar 2, 2022
@wagoodman wagoodman self-assigned this Mar 2, 2022
@wagoodman wagoodman marked this pull request as ready for review March 2, 2022 16:43
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman
Copy link
Contributor Author

I have a parallel PR going that shows the behavior from a fork: #859 (not intended to be merged)

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@github-actions
Copy link

github-actions bot commented Mar 2, 2022

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.68ms ±10%    1.37ms ± 1%  -18.28%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            4.11ms ± 4%    3.46ms ± 0%  -15.65%  (p=0.016 n=5+4)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.35ms ± 3%    1.12ms ± 0%  -16.62%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         976µs ± 2%     811µs ± 0%  -16.97%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                    1.18ms ± 7%    0.95ms ± 1%  -18.99%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                     1.03ms ± 1%    0.85ms ± 1%  -17.63%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      26.4ms ± 5%    23.7ms ± 1%  -10.11%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.58ms ± 3%    1.35ms ± 1%  -14.97%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.29µs ± 5%    1.99µs ± 1%  -12.94%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               259kB ± 0%     258kB ± 0%   -0.34%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            1.12MB ± 0%    1.12MB ± 0%   -0.25%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     265kB ± 0%     265kB ± 0%   -0.16%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         210kB ± 0%     209kB ± 0%   -0.40%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     257kB ± 0%     256kB ± 0%   -0.38%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      237kB ± 0%     236kB ± 0%     ~     (p=0.095 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      4.25MB ± 0%    4.23MB ± 0%   -0.59%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.31MB ± 0%    1.31MB ± 0%   -0.08%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            608B ± 0%      608B ± 0%     ~     (all equal)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               6.61k ± 0%     6.61k ± 0%     ~     (p=0.444 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             23.6k ± 0%     23.6k ± 0%     ~     (p=0.881 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     7.69k ± 0%     7.69k ± 0%     ~     (p=0.556 n=4+5)
ImagePackageCatalogers/javascript-package-cataloger-2         5.41k ± 0%     5.41k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     7.18k ± 0%     7.18k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      6.85k ± 0%     6.85k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       88.4k ± 0%     88.4k ± 0%     ~     (p=0.889 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      7.76k ± 0%     7.76k ± 0%     ~     (p=0.095 n=4+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            14.0 ± 0%      14.0 ± 0%     ~     (all equal)

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman requested a review from a team March 2, 2022 17:32
@wagoodman wagoodman marked this pull request as ready for review March 2, 2022 17:34
@wagoodman wagoodman removed the WIP work in progress / do not merge label Mar 2, 2022
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BASH magic there :)

@wagoodman wagoodman enabled auto-merge (squash) March 2, 2022 17:44
@wagoodman wagoodman merged commit 635904f into main Mar 2, 2022
@wagoodman wagoodman deleted the reduce-pr-pain branch March 2, 2022 17:51
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants