Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor command package to remove globals and add dependency injection #965

Merged
merged 17 commits into from
Apr 26, 2022
Merged

refactor command package to remove globals and add dependency injection #965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1eaa471
wip
spiffcs Apr 15, 2022
d584cde
remove global configuration for local command construction
spiffcs Apr 18, 2022
a9f96fe
reinsert parser logic
spiffcs Apr 18, 2022
c78c1bf
Merge branch 'main' into command-package-refactor
spiffcs Apr 19, 2022
da37845
update static analysis
spiffcs Apr 19, 2022
acd1d29
update unit tests
spiffcs Apr 19, 2022
b68b6f9
update snapshot command and add package options RC
spiffcs Apr 19, 2022
bcef904
update make validate-cyclonedx-schema
spiffcs Apr 19, 2022
dbc17ed
restore attest, poweruser command
spiffcs Apr 20, 2022
d08f9f0
update CLI failures
spiffcs Apr 21, 2022
7957beb
refactor commands; config printed before validation
spiffcs Apr 21, 2022
d76841c
static analysis
spiffcs Apr 21, 2022
dd28f1e
pr review comments
spiffcs Apr 21, 2022
8b3c2ac
static analysis fix
spiffcs Apr 22, 2022
e0b9b1a
add completion command back to pattern
spiffcs Apr 22, 2022
09c3957
typo updates
spiffcs Apr 26, 2022
8567543
remove invalid test
spiffcs Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .bouncer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ permit:
- MPL.*
- ISC
ignore-packages:
- .
spiffcs marked this conversation as resolved.
Show resolved Hide resolved
# packageurl-go is released under the MIT license located in the root of the repo at /mit.LICENSE
- github.com/anchore/packageurl-go

Expand Down
3 changes: 3 additions & 0 deletions .goreleaser.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ before:

builds:
- id: linux-build
dir: ./cmd/syft
binary: syft
goos:
- linux
Expand All @@ -32,6 +33,7 @@ builds:
-X github.com/anchore/syft/internal/version.gitDescription={{.Summary}}

- id: darwin-build
dir: ./cmd/syft
binary: syft
goos:
- darwin
Expand All @@ -49,6 +51,7 @@ builds:
- ./.github/scripts/apple-signing/sign.sh "{{ .Path }}" "{{ .IsSnapshot }}" "{{ .Target }}"

- id: windows-build
dir: ./cmd/syft
binary: syft
goos:
- windows
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ lint-fix: ## Auto-format all source code + run golangci lint fixers

.PHONY: check-licenses
check-licenses: ## Ensure transitive dependencies are compliant with the current license policy
$(TEMPDIR)/bouncer check
$(TEMPDIR)/bouncer check ./cmd/syft
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wagoodman if I provide the path to the main package does the bouncer check things at the top level like internal or syft?


check-go-mod-tidy:
@ .github/scripts/go-mod-tidy-check.sh && echo "go.mod and go.sum are tidy!"
Expand Down
322 changes: 0 additions & 322 deletions cmd/attest.go
View file
Open in desktop

This file was deleted.

31 changes: 0 additions & 31 deletions cmd/check_for_application_update.go
View file
Open in desktop

This file was deleted.

Loading