Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read Go main module version as is - (devel) #981

Merged
merged 2 commits into from
May 4, 2022

Conversation

jonasagx
Copy link
Contributor

@jonasagx jonasagx commented May 3, 2022

closes #959

Signed-off-by: Jonas Galvão Xavier jonasx@anchore.com

Signed-off-by: Jonas Galvão Xavier <jonasx@anchore.com>
@jonasagx jonasagx self-assigned this May 3, 2022
@jonasagx jonasagx marked this pull request as draft May 3, 2022 06:59
Signed-off-by: Jonas Galvão Xavier <jonasx@anchore.com>
@spiffcs
Copy link
Contributor

spiffcs commented May 3, 2022

@jonasagx can you put this in ready for review? I'll give it a 👍 and we can merge it in. Thanks @samj1912 for the response.

@jonasagx jonasagx marked this pull request as ready for review May 3, 2022 19:21
@jonasagx jonasagx merged commit ab28993 into anchore:main May 4, 2022
@jonasagx jonasagx deleted the go-main-module-go1.17-bins branch May 4, 2022 17:47
rigzba21 pushed a commit to rigzba21/syft that referenced this pull request May 5, 2022
* read Go main module version as is - (devel)

Signed-off-by: Jonas Galvão Xavier <jonasx@anchore.com>

* fix package test with default (devel) main module

Signed-off-by: Jonas Galvão Xavier <jonasx@anchore.com>
Signed-off-by: rigzba21 <jonathan.velando01@gmail.com>
spiffcs added a commit that referenced this pull request May 6, 2022
* main:
  feat: add initial dotnet-support (#951)
  unblock timeout for power-user select CLI tests (#985)
  golang cataloger - main module version as is (#986)
  Fix `github-json` output option (#967)
  read Go main module version as is - (devel) (#981)
  reduce logging severity for non-Go binaries (#983)
  golang.org/x/crypto upgrade (#979)
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
* read Go main module version as is - (devel)

Signed-off-by: Jonas Galvão Xavier <jonasx@anchore.com>

* fix package test with default (devel) main module

Signed-off-by: Jonas Galvão Xavier <jonasx@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clearing Go main module version makes creating a CycloneDX 1.3 JSON document difficult
3 participants