-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The existence of python-dbus does not imply the existence of notifications #37
Comments
Hello agg, First of all, thanks a lot for reporting and recommending a fix for these bugs. I do rather appreciate it. However, I am sad to say that both of these bugs are either already fixed in the porcelain branch or those specific parts of the code have been rewritten (e.x. we now use pydbus). So for that reason I am going close both merge requests. Sorry for not communicating that better. |
No problem. Just wanted to make clay usable for me. I'll probably be playing with it more and submitting changes (that you might or might not like) in the near future. |
Any changes would be great. Also, it might be a good idea to work on the Porcelain branch instead since it changes a crazy amount of stuff and merging changes to the master branch back into is going to be major pain. I am also reopening the issue itself since it is valid. |
Fixed #37: Prevent crash setting up dbus without a notification target
From
osd.py
:This resulted in a crash on a barebones environment that does not have a notification system set up, but happened to have the dbus package installed.
The text was updated successfully, but these errors were encountered: