Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for search shortcut #47

Open
agg23 opened this issue Sep 21, 2018 · 3 comments
Open

Option for search shortcut #47

agg23 opened this issue Sep 21, 2018 · 3 comments

Comments

@agg23
Copy link

agg23 commented Sep 21, 2018

Currently the interface essentially forces one to use modifier keys to access most of its functionality, whether that is playing/pausing, adding to the queue, or switching tabs. Interestingly enough, if you bind those functions to single keys, the operations still work, but you can no longer type in a search box.

Ideally this would be toggleable functionality, so if someone binds search to a shortcut (say "s"), then they can use any combination of keys to access other systems, and still be able to type in the search field when "s" is pressed.

@ValentijnvdBeek
Copy link
Collaborator

I agree that this is a problem especially seeing bind a common modifier + keys (e.x. C-c and C-m) to various signals to be backwards compatible with very old systems. This will randomly break people's configurations because it will suddenly not work without any explanation.

So I hundred percent agree and, funnily enough, started working on this just today.

@agg23
Copy link
Author

agg23 commented Sep 21, 2018

I'm glad I created an issue then, because this was probably the next thing I was going to work on :P

@ValentijnvdBeek
Copy link
Collaborator

I wouldn't have recommended it since it requires a pretty big rethink on how Clay hotkeys work in general (which are kinda pain to be honest).

The reason why 40928f9 doesn't include it is because I wanted to be able to easily reverse the commit it if our eternal god emperor @and3rson disagreed with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants