Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #43: Queue next track fix #44

Merged
merged 1 commit into from
Sep 23, 2018

Conversation

agg23
Copy link

@agg23 agg23 commented Sep 20, 2018

The last track in the queue was never playable due to an arithmetic error. This has the side effect of not playing the second track if only two tracks are in the queue.

Merge after #41.

@ValentijnvdBeek
Copy link
Collaborator

Hi Adam,

I'll take a look at this after #41 is merged, but seeing that it is so small it probably going to be alright. In the future it is probably prudent to switch back to the master branch before doing more chances, pushing on the other branch (change is very small) or taking out the commit using a git rebase.

@ValentijnvdBeek ValentijnvdBeek force-pushed the porcelain branch 5 times, most recently from d5fb296 to 3b91f04 Compare September 21, 2018 00:04
@agg23
Copy link
Author

agg23 commented Sep 22, 2018

Fixed #41 requirement

@ValentijnvdBeek ValentijnvdBeek merged commit fc47df5 into and3rson:porcelain Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants