[hdpowerview] Refresh battery level when receiving refresh command (o…

…penhab#11933) * Refresh battery level when receiving REFRESH command. Fixes openhab#11932 Update README with shade refresh logic. Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andan67 · Nov 5, 2022 · d0b9346 · d0b9346
1 parent fa75430
commit d0b9346
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/bundles/org.openhab.binding.hdpowerview/README.md b/bundles/org.openhab.binding.hdpowerview/README.md
@@ -156,6 +156,17 @@ then
 end
 ```
 
+For single shades the refresh takes the item's channel into consideration:
+
+| Channel        | Hard refresh kind |
+|----------------|-------------------|
+| position       | Position          |
+| secondary      | Position          |
+| vane           | Position          |
+| lowBattery     | Battery           |
+| batteryLevel   | Battery           |
+| batteryVoltage | Battery           |
+
 ## Full Example
 
 ### `demo.things` File

diff --git a/...c/main/java/org/openhab/binding/hdpowerview/internal/handler/HDPowerViewShadeHandler.java b/...c/main/java/org/openhab/binding/hdpowerview/internal/handler/HDPowerViewShadeHandler.java
@@ -104,12 +104,25 @@ public void initialize() {
 
     @Override
     public void handleCommand(ChannelUID channelUID, Command command) {
-        if (RefreshType.REFRESH.equals(command)) {
-            requestRefreshShadePosition();
+        String channelId = channelUID.getId();
+
+        if (RefreshType.REFRESH == command) {
+            switch (channelId) {
+                case CHANNEL_SHADE_POSITION:
+                case CHANNEL_SHADE_SECONDARY_POSITION:
+                case CHANNEL_SHADE_VANE:
+                    requestRefreshShadePosition();
+                    break;
+                case CHANNEL_SHADE_LOW_BATTERY:
+                case CHANNEL_SHADE_BATTERY_LEVEL:
+                case CHANNEL_SHADE_BATTERY_VOLTAGE:
+                    requestRefreshShadeBatteryLevel();
+                    break;
+            }
             return;
         }
 
-        switch (channelUID.getId()) {
+        switch (channelId) {
             case CHANNEL_SHADE_POSITION:
                 if (command instanceof PercentType) {
                     moveShade(PRIMARY_ACTUATOR, ZERO_IS_CLOSED, ((PercentType) command).intValue());