pt-br docs #18
Open
pt-br docs #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anders94
reviewed
Jul 26, 2017
README.md
Outdated
| @@ -1,6 +1,9 @@ | |||
| # Blockchain Demo | |||
| A web-based demonstration of blockchain concepts. | |||
|
|
|||
| _NOTE: If you want to read a documentation in Brazilian Portuguese [click this link](https://blockchain4devs.github.io/blockchain-demo/docs/pt-br/). | |||
There was a problem hiding this comment.
Can we do this in another way? Ideally there is a markdown version of the docs that we look to locally on GitHub. Thoughts?
|
@anders94 Agree! I reverted README.md to original and added README.pt-br.md |
anders94
reviewed
Jul 27, 2017
README.md
Outdated
| @@ -1,5 +1,6 @@ | |||
| # Blockchain Demo | |||
| A web-based demonstration of blockchain concepts. | |||
| _(If you want to read this in Brazilian Portuguese [click this link](docs/pt-br/index.html))_. | |||
There was a problem hiding this comment.
Let's change this to simply:
_[Brazilian Portuguese version](docs/pt-br/index.html))_
There was a problem hiding this comment.
Could be:
Brazilian Portuguese version: README.pt-br.md
For me, no problem if this reference isn't inside README.md. In this case, no more modifications are needed. It's up to you! 😄
Do we agree?
|
Hi, @anders94! Do you need some my iteration in this PR in order to approve it? Is it ok for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @anders94!
I would like to say that I loved your blockchain-demo. So, I decided to contribute to it, creating and sharing with my Brazilian friends, docs in our language (pt-br). I created these docs using asciidoctor. I created a GitHub Page where, at this moment, there is a document. Also, there is a PDF version of this document (built from the same sources). If you like it, I would love to participate in the project by offering him these documents.
This week I'm working on produce some videos (in Brazilian Portuguese). They will finish a blockchain presentation that I made to a Java User Group here, in Brasil. Then, I will publish they to YouTube and, ater that, I'll create closed captions for it, in English. I have some ideas about how can I improve the project. Some of them involve updating the code you wrote. I would like to continue to develop the project, along with you.
Thank you!