TTVA-200 | Allow new reservation time to overlap with original time #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorilindell
force-pushed
the
TTVA-200-allow-new-reservation-time-to-overlap-with-original-time
branch
from
acb7a93
to
54d4564
Compare
Allow updated reservation times to overlap with the original times also in the case that disallow_overlapping_reservations is set to True in the resource unit of the reservation
jopesy
reviewed
Sep 24, 2024
| @@ -0,0 +1,21 @@ | |||
| from django.db import migrations | |||
There was a problem hiding this comment.
This shouldn't be included in this PR.
There was a problem hiding this comment.
I already did this change yesterday but forgot to push changes here. Anyway, migration file is now removed
|
Just remove the migration from the PR. Otherwise this looks very good. |
jorilindell
force-pushed
the
TTVA-200-allow-new-reservation-time-to-overlap-with-original-time
branch
from
54d4564
to
cca1b26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow updated reservation times to overlap with the original times also in the case that disallow_overlapping_reservations is set to True in the resource unit of the reservation