Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull requests? #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pull requests? #1

wants to merge 1 commit into from

Conversation

pfalcon
Copy link

@pfalcon pfalcon commented Nov 25, 2014

Hi, would you care to submit pull requests to upstream of your fork? ;-)

Hi, would you care to submit pull requests to upstream of your fork? ;-)
@pfalcon pfalcon changed the title Pull requsts? Pull requests? Nov 25, 2014
@andete
Copy link
Owner

andete commented Nov 26, 2014

Hello,

I've only used this code a bit and in fact switched to using SWD with
J-Link, so I consider this code untested/abandoned.

Joost

On 11/25/2014 07:10 PM, Paul Sokolovsky wrote:

Hi, would you care to submit pull requests to upstream of your fork? ;-)


    You can merge this Pull Request by running

git pull https://github.com/pfalcon/PySWD patch-1

Or view, comment on, or merge it at:

#1

    Commit Summary


Reply to this email directly or view it on GitHub
#1.

Joost Yervante Damad - joost@damad.be - http://damad.be/joost/
http://productize.be Productize | The pre-production agency

@pfalcon
Copy link
Author

pfalcon commented Nov 26, 2014

Yeah, I didn't hack on it in a while too, and yet it would be nice to have a reference SWD implementation in Python - for learning, experimentation, bring up of new hardware, etc. And the only way to let it progress is apparently to collect one-day hacks in one place ;-). So, if there're no other reasons to preclude merging (like licensing, etc.), I encourage you to submit a pull request. If you didn't test it well enough, I'll merge it to a separate branch. Thanks.

@andete
Copy link
Owner

andete commented Nov 27, 2014

On a related note, I got FW uploading via the bootloader working a bit ago, I documented it at http://www.productize.be/efm32-bootloader-scripted-fw-update/
I'm not so convinced about the second commit in my branch, the first one is harmless and in fact makes basic SWD uploading work for the EFM32 Zero-Gecko (Cortex-M0+), be it very slow and sometimes failing.

@andete
Copy link
Owner

andete commented Nov 27, 2014

Let me know what branch you want my changes on master to, the changes on the bootloader branch are not working, if you want them, definitely put them on a branch

@pfalcon
Copy link
Author

pfalcon commented Dec 7, 2014

Sorry - this got backlogged while I was travelling. Please just submit PR for "flashloader" branch, I'll take care of cherry-picking it based on your comments above. (I generally ask for PR from your side as kind of sign-off that you're happy with the original licensing, etc.) Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants