Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConPTY is not fully working in CI #217

Closed
blink1073 opened this issue Mar 2, 2022 · 4 comments · Fixed by #219
Closed

ConPTY is not fully working in CI #217

blink1073 opened this issue Mar 2, 2022 · 4 comments · Fixed by #219
Labels
type:Bug
Milestone
v2.0.4

Comments

@blink1073
Copy link
Collaborator

Re-running a previously passing job shows that ConPTY started timing out on certain tests. We skipped those tests with XFAIL in #213
@andfoy
Copy link
Owner

andfoy commented Mar 3, 2022

This roots out on andfoy/winpty-rs#23

@andfoy
Copy link
Owner

andfoy commented Mar 3, 2022 •
edited
Loading

First note: New CI images use Windows Server 2022, whereas previously they used 2019 and some tests are now running as expected

@andfoy
Copy link
Owner

andfoy commented Mar 3, 2022

Yes, indeed, now tests are passing: andfoy/winpty-rs#24. I'll produce a winpty-rs release and make some changes here

@blink1073
Copy link
Collaborator Author

Nice detective work! Once there is a new pywinpty release I'll try removing the explicit backend in terminado.

@andfoy andfoy mentioned this issue Mar 3, 2022
Merged
@andfoy andfoy added this to the v2.0.4 milestone Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:Bug
Projects
None yet
Milestone
v2.0.4
Development

Successfully merging a pull request may close this issue.

PR: Update winpty-rs to v0.3.4
2 participants
@andfoy @blink1073