Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Update winpty-rs to v0.3.4 #219

Merged
merged 6 commits into from
Mar 4, 2022
Merged

PR: Update winpty-rs to v0.3.4 #219

merged 6 commits into from
Mar 4, 2022

Conversation

andfoy
Copy link
Owner

@andfoy andfoy commented Mar 3, 2022 •
edited
Loading

Fixes #217
Fixes #218

@andfoy andfoy added this to the v2.0.4 milestone Mar 3, 2022
@andfoy
Copy link
Owner Author

andfoy commented Mar 4, 2022

Great news @blink1073, this restores the previous blocking behaviour on our tests

@andfoy andfoy merged commit e68937e into andfoy:master Mar 4, 2022
@andfoy andfoy deleted the update_winpty_rs_0.3.4 branch March 4, 2022 00:38
blink1073
blink1073 approved these changes Mar 4, 2022
View reviewed changes
Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.4
Development

Successfully merging this pull request may close these issues.

Build failure on windows py3.6 ConPTY is not fully working in CI
2 participants
@andfoy @blink1073