PtyProcess is leaking conhosts

[deathaxe]

It seems, required conhost processes to run a shell interpreter are not terminated after closing a terminal session.

Actually initial call opens 2 conhosts. Each subsequent session spawns another one, even though previous one is closed.

Steps:

1. Open Windows task manager

   0 conhost.exe processes running

2. Invoke:

   >>> from winpty import PtyProcess
   >>> proc = PtyProcess.spawn('python')
   >>> proc.close()
   

   2 conhost.exe processes running

3. Invoke:

   >>> proc = PtyProcess.spawn('python')
   >>> proc.close()
   

   3 conhost.exe processes running

4. Invoke:

   >>> proc = PtyProcess.spawn('python')
   >>> proc.close()
   

   4 conhost.exe processes running

5. ...

[kaste]

I also wanted to point that out that you never touch self.pty in close. https://github.com/andfoy/pywinpty/blob/main/winpty/ptyprocess.py#L152 is commented but was in there before, I couldn't find a commit which explains this call had to be removed. I would have expected that https://github.com/andfoy/winpty-rs/blob/main/src/pty/base.rs#L673-L674 must be executed on gc (is it?) but you also pass it to a daemon thread. Maybe the daemon never stops?

[deathaxe]

Yet another example for Rust not being the holy grale.