Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error C2664 on win32 #192

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Fix compile error C2664 on win32 #192

merged 1 commit into from
Nov 11, 2021

Conversation

cgohlke
Copy link
Contributor

@cgohlke cgohlke commented Oct 31, 2021

Fixes compile errors on win32 (32-bit Windows binaries):

    src/csrc/conpty_common.cpp(40): error C2664: 'BOOL InitializeProcThreadAttributeList(LPPROC_THREAD_ATTRIBUTE_LIST,DWORD,DWORD,PSIZE_T)': cannot convert argument 4 from 'size_t *' to 'PSIZE_T'
    src/csrc/conpty_common.cpp(40): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
    C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um\processthreadsapi.h(673): note: see declaration of 'InitializeProcThreadAttributeList'
    src/csrc/conpty_common.cpp(50): error C2664: 'BOOL InitializeProcThreadAttributeList(LPPROC_THREAD_ATTRIBUTE_LIST,DWORD,DWORD,PSIZE_T)': cannot convert argument 4 from 'size_t *' to 'PSIZE_T'
    src/csrc/conpty_common.cpp(50): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
    C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um\processthreadsapi.h(673): note: see declaration of 'InitializeProcThreadAttributeList'

@andfoy andfoy added this to the v1.1.6 milestone Nov 11, 2021
@andfoy andfoy merged commit 3725d83 into andfoy:master Nov 11, 2021
@andfoy
Copy link
Owner

andfoy commented Nov 11, 2021

Thanks for this contribution @cgohlke!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants