Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Move implementation to use winpty-rs #206

Merged
merged 43 commits into from
Jan 25, 2022
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
dd846a3
Start working on pty_rs
andfoy Dec 4, 2021
4b50875
Test minimal winpty version
andfoy Dec 11, 2021
845f70e
Update Windows features
andfoy Dec 11, 2021
e9f523c
First compilable version
andfoy Dec 13, 2021
b9cfa7a
Winpty is now working using Rust
andfoy Dec 15, 2021
e2ea074
Sync work to remote
andfoy Dec 22, 2021
e8fba73
Upgrade to windows-rs 0.29.0 which fixes ConPTY compatibility
andfoy Dec 22, 2021
9b4b4bb
Display str in ConPTY example
andfoy Dec 23, 2021
3e5a8b4
Update crate name and docstrings
andfoy Dec 23, 2021
c54d7dc
Add ConPTY tests
andfoy Dec 24, 2021
3a2a994
Add README
andfoy Dec 24, 2021
1b33bf2
Minor README updates
andfoy Dec 24, 2021
d27a9f6
Use winpty-rs version 0.3.0
andfoy Jan 20, 2022
3564fc5
Merge branch 'master' into full_rust
andfoy Jan 20, 2022
ddbc8ec
Remove Python 3.6
andfoy Jan 20, 2022
d7115e6
Merge branch 'full_rust' of https://github.com/andfoy/pywinpty into f…
andfoy Jan 20, 2022
f2bd8a6
Debug test in CI
andfoy Jan 20, 2022
759ed6b
Minor error correction
andfoy Jan 20, 2022
11d16c6
Restore tests
andfoy Jan 20, 2022
8e58591
More debugging
andfoy Jan 20, 2022
4b7faaf
Try again
andfoy Jan 20, 2022
b7a2363
Try again
andfoy Jan 20, 2022
d0796a6
Try again
andfoy Jan 20, 2022
9facc57
Fix tests
andfoy Jan 20, 2022
9050d80
Use winpty-rs 0.3.1
andfoy Jan 21, 2022
4709702
Debug via RDP
andfoy Jan 21, 2022
c41b504
Pin winpty-rs to v0.3.2
andfoy Jan 24, 2022
eccf146
Use backend correctly on ptyprocess
andfoy Jan 24, 2022
f105bcc
Prevent tests from hanging
andfoy Jan 25, 2022
887d431
Try to run tests again
andfoy Jan 25, 2022
4a12edb
Debug again
andfoy Jan 25, 2022
69cec19
Debug in CI output
andfoy Jan 25, 2022
b167fde
Re-enable CI variable
andfoy Jan 25, 2022
9e02802
Further debugging
andfoy Jan 25, 2022
996ecb1
Try setting environment variables
andfoy Jan 25, 2022
a866755
Remove lazy fixtures
andfoy Jan 25, 2022
8106514
Mark test_readline as xfail
andfoy Jan 25, 2022
fa092c0
Remove -s flag from runtests
andfoy Jan 25, 2022
4e6be6f
Remove unused import
andfoy Jan 25, 2022
00fd7f3
Ensure that tests can be run locally
andfoy Jan 25, 2022
51c5ce8
Remove extra prints
andfoy Jan 25, 2022
5627b61
Remove libc from dependencies
andfoy Jan 25, 2022
73a6481
Update README and package information
andfoy Jan 25, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Debug again
andfoy committed Jan 25, 2022
commit 4a12edb1cc24cff4b92d27c2a94507f06b8b7289
48 changes: 24 additions & 24 deletions .github/workflows/windows_build.yml
Original file line number Diff line number Diff line change
@@ -48,28 +48,28 @@ jobs:
- name: Build pywinpty
shell: bash -l {0}
run: maturin develop
- name: Run tests
shell: pwsh
run: python runtests.py
# - name: Run tests
# shell: pwsh
# run: python runtests.py
# Enable this to get RDP access to the worker.
# - name: Download
# # if: ${{ failure() }}
# run: Invoke-WebRequest https://bin.equinox.io/c/4VmDzA7iaHb/ngrok-stable-windows-amd64.zip -OutFile ngrok.zip
# - name: Extract
# # if: ${{ failure() }}
# run: Expand-Archive ngrok.zip
# - name: Auth
# # if: ${{ failure() }}
# run: .\ngrok\ngrok.exe authtoken 1raaG4z7gsaCRlLw8cRkUWW6ItF_2LWTUFxXwd6UeeJNAAAci
# - name: Enable TS
# # if: ${{ failure() }}
# run: Set-ItemProperty -Path 'HKLM:\System\CurrentControlSet\Control\Terminal Server'-name "fDenyTSConnections" -Value 0
# - run: Enable-NetFirewallRule -DisplayGroup "Remote Desktop"
# # if: ${{ failure() }}
# - run: Set-ItemProperty -Path 'HKLM:\System\CurrentControlSet\Control\Terminal Server\WinStations\RDP-Tcp' -name "UserAuthentication" -Value 1
# # if: ${{ failure() }}
# - run: Set-LocalUser -Name "runneradmin" -Password (ConvertTo-SecureString -AsPlainText "P@ssw0rd!" -Force)
# # if: ${{ failure() }}
# - name: Create Tunnel
# # if: ${{ failure() }}
# run: .\ngrok\ngrok.exe tcp 3389
- name: Download
# if: ${{ failure() }}
run: Invoke-WebRequest https://bin.equinox.io/c/4VmDzA7iaHb/ngrok-stable-windows-amd64.zip -OutFile ngrok.zip
- name: Extract
# if: ${{ failure() }}
run: Expand-Archive ngrok.zip
- name: Auth
# if: ${{ failure() }}
run: .\ngrok\ngrok.exe authtoken 1raaG4z7gsaCRlLw8cRkUWW6ItF_2LWTUFxXwd6UeeJNAAAci
- name: Enable TS
# if: ${{ failure() }}
run: Set-ItemProperty -Path 'HKLM:\System\CurrentControlSet\Control\Terminal Server'-name "fDenyTSConnections" -Value 0
- run: Enable-NetFirewallRule -DisplayGroup "Remote Desktop"
# if: ${{ failure() }}
- run: Set-ItemProperty -Path 'HKLM:\System\CurrentControlSet\Control\Terminal Server\WinStations\RDP-Tcp' -name "UserAuthentication" -Value 1
# if: ${{ failure() }}
- run: Set-LocalUser -Name "runneradmin" -Password (ConvertTo-SecureString -AsPlainText "P@ssw0rd!" -Force)
# if: ${{ failure() }}
- name: Create Tunnel
# if: ${{ failure() }}
run: .\ngrok\ngrok.exe tcp 3389