Require PTYImpl trait to implement Send and Sync

andfoy · Jan 11, 2022 · fd6be6c · fd6be6c
1 parent 48efc81
commit fd6be6c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/pty/base.rs b/src/pty/base.rs
@@ -18,7 +18,7 @@ use std::os::windows::ffi::OsStrExt;
 use super::PTYArgs;
 
 /// This trait should be implemented by any backend that wants to provide a PTY implementation.
-pub trait PTYImpl {
+pub trait PTYImpl: Sync + Send {
     /// Create a new instance of the PTY backend.
     ///
     /// # Arguments

diff --git a/src/pty/conpty/pty_impl.rs b/src/pty/conpty/pty_impl.rs
@@ -41,6 +41,9 @@ pub struct ConPTY {
     process: PTYProcess
 }
 
+unsafe impl Send for ConPTY {}
+unsafe impl Sync for ConPTY {}
+
 impl PTYImpl for ConPTY {
     fn new(args: &PTYArgs) -> Result<Box<dyn PTYImpl>, OsString> {
         let mut result: HRESULT = S_OK;