Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix some unstable issues related to reading testing on CI #11

Merged
merged 6 commits into from
Jan 21, 2022

Conversation

andfoy
Copy link
Owner

@andfoy andfoy commented Jan 21, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2022

Codecov Report

Merging #11 (0ddd8d2) into main (1de4e0a) will increase coverage by 0.60%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   74.32%   74.93%   +0.60%     
==========================================
  Files           8        8              
  Lines        1192     1217      +25     
==========================================
+ Hits          886      912      +26     
+ Misses        306      305       -1     
Flag Coverage Δ
unittests 74.93% <100.00%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pty/base.rs 73.18% <100.00%> (+2.01%) ⬆️
tests/conpty.rs 71.97% <100.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de4e0a...0ddd8d2. Read the comment docs.

@andfoy andfoy changed the title [DEBUG] Debug ci stdandard streams on the reading thread PR: Fix some unstable issues related to reading testing on CI Jan 21, 2022
@andfoy andfoy added this to the v0.3.1 milestone Jan 21, 2022
@andfoy andfoy merged commit aa4ddf6 into main Jan 21, 2022
@andfoy andfoy deleted the debug_ci_std branch January 21, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants