Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix some issues related to wstring creation in winpty spawn arguments #13

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

andfoy
Copy link
Owner

@andfoy andfoy commented Jan 24, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #13 (f1e95f1) into main (7158431) will decrease coverage by 0.14%.
The diff coverage is 64.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   74.64%   74.50%   -0.15%     
==========================================
  Files           8        8              
  Lines        1203     1208       +5     
==========================================
+ Hits          898      900       +2     
- Misses        305      308       +3     
Flag Coverage Δ
unittests 74.50% <64.70%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pty/winpty/pty_impl.rs 76.70% <64.70%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e018ca9...f1e95f1. Read the comment docs.

@andfoy andfoy merged commit 84dc709 into main Jan 24, 2022
@andfoy andfoy deleted the fix_winpty_args branch January 24, 2022 19:55
@andfoy andfoy added this to the v0.3.2 milestone Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants