Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Improve read performance and rewrite iseof #8

Merged
merged 11 commits into from
Jan 19, 2022

Conversation

andfoy
Copy link
Owner

@andfoy andfoy commented Jan 19, 2022

This PR makes important changes to improve reading performance, as well as detecting if a process reached End-Of-Line.

@andfoy andfoy added this to the v0.3.0 milestone Jan 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #8 (da58d85) into main (e9886c1) will increase coverage by 2.54%.
The diff coverage is 68.62%.

❗ Current head da58d85 differs from pull request most recent head 4da0266. Consider uploading reports for the commit 4da0266 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   45.62%   48.16%   +2.54%     
==========================================
  Files           9       10       +1     
  Lines        1690     1823     +133     
==========================================
+ Hits          771      878     +107     
- Misses        919      945      +26     
Flag Coverage Δ
unittests 48.16% <68.62%> (+2.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/lib.rs 0.85% <ø> (ø)
src/pty.rs 64.63% <25.00%> (-2.46%) ⬇️
src/pty/winpty/pty_impl.rs 77.77% <25.00%> (-1.39%) ⬇️
tests/conpty.rs 71.33% <50.00%> (+20.65%) ⬆️
src/pty/conpty/pty_impl.rs 70.49% <52.94%> (-1.13%) ⬇️
src/pty/base.rs 70.53% <74.23%> (-3.08%) ⬇️
src/pty/winpty/bindings.rs 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9886c1...4da0266. Read the comment docs.

@andfoy andfoy merged commit d9cb207 into main Jan 19, 2022
@andfoy andfoy deleted the performance_improvements branch January 19, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants