Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #543 more properly identify CREATE TABLE ... LIKE ... statements #767

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

markjm
Copy link

@markjm markjm commented Mar 12, 2024

Resolves #543.

By skipping over setting LIKE statements as Comparisons during lexing phase. We then more thoroughly check its usage during grouping. If we are creating a TABLE (identified based on the rigid syntax documented here https://dev.mysql.com/doc/refman/8.0/en/create-table-like.html), then dont group as a Comparison, otherwise treat it as we did before.

  • ran the tests (pytest)
  • all style issues addressed (flake8)
  • your changes are covered by tests
  • [n/a] your changes are documented, if needed

@markjm markjm force-pushed the mmolinaro/fix-543 branch from 945c80c to 8362373 Compare March 12, 2024 06:42
@markjm
Copy link
Author

markjm commented Mar 12, 2024

cc @reata who opened the relevant issue and @andialbrecht as the maintainer of this awesome project :)

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.06%. Comparing base (7334ac9) to head (8362373).
Report is 20 commits behind head on master.

❗ Current head 8362373 differs from pull request most recent head 1995a8c. Consider uploading reports for the commit 1995a8c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
+ Coverage   97.04%   97.06%   +0.01%     
==========================================
  Files          20       20              
  Lines        1558     1566       +8     
==========================================
+ Hits         1512     1520       +8     
  Misses         46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markjm
Copy link
Author

markjm commented Mar 18, 2024

@andialbrecht resolved merge conflicts with recently merged #740

@markjm
Copy link
Author

markjm commented May 8, 2024

Hi @andialbrecht just wanted to check in on this change. Is this something you would be interested in incorporating? If so, i can keep the branch conflict-free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Create Table table_name Like existing_table_name" DDL Support
1 participant