Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwin: Fix uiTable checkbox change not calling SetCellValue(). #509

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

szanni
Copy link

@szanni szanni commented Aug 27, 2020

This is something that came up while trying things out with the new tester for uiTable suggested in #508:

The SetCellValue() when clicking a checkbox within a uiTable is never called.
The UI happiliy updates suggesting the value has been set - which is not actually the case.

The checkbox not redrawing with the actual check box value from the model is another related issue, see #507.

As a general question regarding PRs fixing issues: should I open a separate issue every time? Or is the PR fixing the issue enough? I couldn't find anything in CONTRIBUTING.md

The SetCellValue() when clicking a checkbox within a uiTable is
never called. The UI happiliy updates suggesting the value has
been set - which is not actually the case.

The checkbox not redrawing with the actual check box value from
the model is another related issue, see andlabs#507.
@szanni szanni changed the title darwin: Fix uiTable checkbox value not calling SetCellValue(). darwin: Fix uiTable checkbox change not calling SetCellValue(). Aug 27, 2020
@szanni szanni mentioned this pull request Dec 1, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant