Production level logging for the plugin. #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We print logs through Facebook logger only. This way application could customize if logs need to be saved on disk or have some custom processing. Instead of printing stacktraces we let FLog class to figure out how to handle it. Log levels are changed in the way that important logs wouldn't be filtered out by default log policy in release.
dryganets
force-pushed
the
sergeyd/production-logging
branch
from
69efbf9
to
164d7d8
Compare
|
Very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We print logs through Facebook logger only. This way application could customize if logs need to be saved on disk or have some custom processing.
Instead of printing stack traces we let FLog class to figure out how to handle it.
Log levels are changed in the way that important logs wouldn't be filtered out by default log policy in the release.
All logs have the same tags so a problem could be easily associated with the plugin.