-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old rnpm for react-native 0.60 #361
Conversation
Looks nice, I will try to test it later today. I would favor that we keep the existing |
I found this part of migration guide and fixed the react-native.config.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reformat using 2 spaces for tabs.
How we can do android link with |
@brodybits I had read on migration guide, and see this info:
It's not because react-native version, but the cli version, since react-native ^0.59 they are independent. |
@andpor any more changes request? |
Enable autolink
+1 can we help move this along in any way? |
I'll create a another npm package for solve this problem. |
I don’t think creating another npm package solves any problems. That just spreads the community out more. This package has weekly downloads and many contributors in just think it would be helpful if the owner or maintainer was a little more active or delegated permissions for keeping PRs like this moving along for the library.
…Sent from my iPhone
On Aug 21, 2019, at 9:40 AM, Carlos Roberto ***@***.***> wrote:
I'll create a another npm package for solve this problem.
This PR has more a month, and not had activity.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Yes not solve, it's only a idea
I used on my personal project, and autolink works like a charm. |
The PR is merged and released under 4.0.0 - sorry for delay, quite busy lately. 4.0.0 has been published to npm. |
The burden on library maintainers for react-native 0.60 (both in their paying project work, and whatever libraries they maintain) is pretty serious, and it's vacation season - glad to see this merged but everyone be as helpful as you can in the libraries you use, pretty much like submitting the PR here (❤️) and being patient. Cheers |
I have folow this migration guide for fix the rn60 warning
I don't have time to test this change yet, but I accept any feedbacks
#359