Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve some parser failure messages #1

Conversation

declension
Copy link

Thanks for a great port to 0.19! Super useful.
Couldn't file an issue so made a small PR directly instead:

Fixes made

  • Most importantly: Int was failing with expected an Float
  • Also, expected whitespace for \s* was perhaps misleading, so changed to expected optional whitespace (even though this will probably never fail 😁)
  • Others fixed for better consistency / English

 * Most importantly: `Int` was failing _with expected an Float_
 * Also, _expected whitespace_ for `\s*` was perhaps misleading, so changed to _expected optional whitespace_ (even though this will probably never fail 😁)
 * Others fixed for better consistency / English
@andre-dietrich andre-dietrich merged commit 0bb23b4 into andre-dietrich:master Apr 12, 2019
@andre-dietrich
Copy link
Owner

Thanks a lot ... the elm-package is also up-to-date with your changes ;)

@declension declension deleted the fix-some-parser-failure-messages branch April 12, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants